mtn-media-group/mtn_go_sevdesk
Watch
1
0
Fork
You've already forked mtn_go_sevdesk
 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

feat: add OmitTaxType for bookkeeping 2.0 sales documents #1

Merged
Mats merged 1 commit from feat/invoice-omit-tax-type into main 2026-10-09 18:26:58 +00:00
Conversation 0 Commits 1 Files changed 7 +46 -5
Mats commented 2026-10-09 18:25:14 +00:00
Owner
Copy link

Adds OmitTaxType (json:"-") to sales.InvoiceCreate, sales.CreditNoteCreate and sales.OrderCreate. When it is set, the factory body sends taxRule alone: it omits both an explicit TaxType and the one the library normally derives from the rule. Consumers set the flag when Basics.BookkeepingSystemVersion reports 2.0, so they no longer depend on sevdesk's transitional mapping of taxType.

  • Without the flag the behavior is unchanged; the existing golden bodies still assert taxType for 1.0.
  • TestOmitTaxType covers all three factories. A mutation test showed that each missing clear fails its own subtest.
  • Docs updated: sales/doc.go, the struct comments, README and the CHANGELOG [0.1.1] entry.

Once this is merged, tag the merge commit as v0.1.1. mtn-backend's sevdesk migration (branch feat/sevdesk-sdk-migration) depends on that tag.

Checks: the pre-push hook ran every step of ci.yml with Go 1.26.9, matching the CI lint job (gofmt, vet, go test -race, check-comments, staticcheck v0.8.1, govulncheck, build), and all passed. Two clean review rounds in a row from both Opus and Sol.

Note: staticcheck v0.8.1 cannot load packages built with Go 1.27 (export data v5), so the pre-push hook fails on Go 1.27 hosts. CI lint pins 1.26, so CI is unaffected.

Adds `OmitTaxType` (`json:"-"`) to `sales.InvoiceCreate`, `sales.CreditNoteCreate` and `sales.OrderCreate`. When it is set, the factory body sends `taxRule` alone: it omits both an explicit `TaxType` and the one the library normally derives from the rule. Consumers set the flag when `Basics.BookkeepingSystemVersion` reports 2.0, so they no longer depend on sevdesk's transitional mapping of `taxType`. - Without the flag the behavior is unchanged; the existing golden bodies still assert `taxType` for 1.0. - `TestOmitTaxType` covers all three factories. A mutation test showed that each missing clear fails its own subtest. - Docs updated: `sales/doc.go`, the struct comments, README and the CHANGELOG `[0.1.1]` entry. Once this is merged, tag the merge commit as `v0.1.1`. mtn-backend's sevdesk migration (branch `feat/sevdesk-sdk-migration`) depends on that tag. Checks: the pre-push hook ran every step of `ci.yml` with Go 1.26.9, matching the CI lint job (gofmt, vet, `go test -race`, check-comments, staticcheck v0.8.1, govulncheck, build), and all passed. Two clean review rounds in a row from both Opus and Sol. Note: staticcheck v0.8.1 cannot load packages built with Go 1.27 (export data v5), so the pre-push hook fails on Go 1.27 hosts. CI lint pins 1.26, so CI is unaffected.
feat: add OmitTaxType for bookkeeping 2.0 sales documents
Some checks failed
CI / test (1.26) (pull_request) Has been cancelled
Details
CI / test (1.27) (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / test (1.26) (push) Successful in 33s
Details
CI / lint (push) Successful in 32s
Details
CI / build (push) Successful in 18s
Details
CI / test (1.27) (push) Successful in 27s
Details
0c95fa60cf
Mats merged commit ff8a216d5e into main 2026-10-09 18:26:58 +00:00
Mats deleted branch feat/invoice-omit-tax-type 2026-10-09 18:26:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mtn-media-group/mtn_go_sevdesk!1
No description provided.